As an FS admin I would like to have an easy way of noticing that a report has been generated after I click the button.

ASprinkle commented 6 years ago

Notes

Currently, after you click the generate report button, the page populates the report and the FS admin has to notice the change on the page and scroll down.

508 has similar issues with this page

Acceptance criteria

[x] reader can see report after it is produced

Tasks

[x] add scroll to first report element after report success
[x] Fix bug where user is redirected to admin/applications after login instead of requesting url (seth)
[x] check in usability session to make sure that the report location is clear and that they need to scroll up to do a different report (Bryan)

Definition of Done

[x] Code unit / e2e tested and comply with QWASP
[x] No new security vulnerabilities
[x] Internal team code review
[x] Documentation / readme.md / CircleCI updated
[x] Docker updated
[x] Compare finished design with mockup
[x] Usability tested

sadlerw commented 6 years ago

This is on staging - please test with an admin user @bryanmcfadden and complete the last task above.

sadlerw commented 6 years ago

ASprinkle commented 6 years ago

Not sure if this is a bug: I went to https://forest-service-trees-staging.app.cloud.gov/admin/christmas-trees/reports and I saw this on the page:

I also noticed that URL was different... admin/applications...

Then I tried to recreate the issue and it didn't happen again....but I thought I should share here.

bryanmcfadden commented 6 years ago

Same thing happened to me. It sent me to the pending permit applications page as well. @sadlerw - I'll test the report with my next admin session.

sadlerw commented 6 years ago

That’s after relogging in? That’s a bug then.

sadlerw commented 6 years ago

bug is fixed on staging if you want to try and reproduce again @ASprinkle

ASprinkle commented 6 years ago

This looks great to me! very obvious now.

empowerai / fs-permit-platform