search

empowerhack / DrawMyLife-Service

API and Admin system for the Draw My Life initiative - Volunteers: check README and GitHub Projects to get started.
https://github.com/empowerhack/DrawMyLife-Service/projects
MIT License
13 stars 0 forks source link

Increase text limit and only show elipses if text too long #102

Closed steverabino closed 7 years ago

steverabino commented 7 years ago

Currently, we always add ellipses to the end of description and story on the index page, even if they haven't been trimmed.

This increases the limit to 100 characters, and will only add ellipses if the content has been trimmed

Before

image

After

image

krissy commented 7 years ago

The "ellipses always being there" was definitely a FIXME! \o/ In terms of text length, makes sense to fill the square while the layout is locked visualising it now as opposed to wireframe stage. Once this page is responsive we can revisit and make it shorter if it makes visual sense? As long as @tanyapowell is happy with that for now then LGTM :+1:

steverabino commented 7 years ago

Merging - we can reduce the character count later if we see length is way to long when looking at live data