search

empowerhack / DrawMyLife-Service

API and Admin system for the Draw My Life initiative - Volunteers: check README and GitHub Projects to get started.
https://github.com/empowerhack/DrawMyLife-Service/projects
MIT License
13 stars 0 forks source link

Mood ratings changed from 1-10 to 1-5 #129

Closed tanyapowell closed 7 years ago

tanyapowell commented 7 years ago

Addresses issue: #113

What this does

Feedback from the Serbia pilot indicated that a rating of 1-10 was confusing. Rating changed to 1-5 for a short term solution

Screenshots

Before

image

After

image

EChesters commented 7 years ago

Pulled down and checked. All works on my laptop and code looks good 👍 Feel free to merge.

tanyapowell commented 7 years ago

thanks @EChesters

krissy commented 7 years ago

Sorry for the late review on this! All looks good frontend-wise :) However, there's still a backend task to backfill the existing data so they're not rated outside of our new range, and also update the rails model validations accordingly so won't close the original issue just yet.

tanyapowell commented 7 years ago

Oh right...will need to re-open that issue. Maybe we need to agree as a team what's the best way to tackle opening and closing issues when there are frontend and backend tasks. Maybe use a checklist for subtasks and once every has been ticked off then the issue is closed?