search

empowerhack / DrawMyLife-Service

API and Admin system for the Draw My Life initiative - Volunteers: check README and GitHub Projects to get started.
https://github.com/empowerhack/DrawMyLife-Service/projects
MIT License
13 stars 0 forks source link

163 move to cloudinary #166

Closed kevinpmcc closed 1 year ago

kevinpmcc commented 7 years ago

Addresses issue: #163

What this does

This is my first qa pull request on project so any feedback about style, practices etc. would be very much appreciated.

The data around image_content_type, image_file_size, and image_updated_at in the drawing table were being added automatically through paperclip i think. They are not currently being filled. I can manually create these as part of drawing object as the file is uploaded if we want. Could you let me know if this data is being used?

I have no tests currently for this, need to investigate more exactly what need to tested without uploading to cloudinary.

Screenshots

hopefully all the same for users!

kevinpmcc commented 7 years ago

updated all based on comments, thanks @krissy validations now working by moving validate :image, presence: true below mount_uploader the extension_whitelist validation error is now displayed. this didn't exist so is added to en.yml file.