empowerhack / DrawMyLife-Service

API and Admin system for the Draw My Life initiative - Volunteers: check README and GitHub Projects to get started.
https://github.com/empowerhack/DrawMyLife-Service/projects
MIT License
13 stars 0 forks source link

Add country data to drawings #38

Closed steverabino closed 8 years ago

steverabino commented 8 years ago

To address https://github.com/empowerhack/DrawMyLife-Service/issues/31

Adds string location to Users and Drawings

For Users, this will be required on sign-up (or next profile edit), and will show Greece, Hungary, and Serbia are preferential countries (though all are shown)

image

For Drawings, if a new drawing is being created, it will default to the current user's country, but can be changed when entering details for the picture

image

If an existing drawing is being edited (that has no country data), it will default to nil ("Country picture was drawn in"), as it could lead to accidentally updating the pic with the wrong data.

image

steverabino commented 8 years ago

Known Issue: There are a few instances of priority countries for dropdowns. These are hardcoded so far to Greece, Hungary, and Serbia.

Once we have an app-wide settings view, this can be integrated into that.

steverabino commented 8 years ago

@krissy - all good for review 🙈

krissy commented 8 years ago

Awesome work! 💃 Just a couple of little comments but overall :+1: :D