empowerhack / DrawMyLife-Service

API and Admin system for the Draw My Life initiative - Volunteers: check README and GitHub Projects to get started.
https://github.com/empowerhack/DrawMyLife-Service/projects
MIT License
13 stars 0 forks source link

[#75] Fix pagination issue, some link fixes and enable drawing edit/delete access to same organisation users #77

Closed krissy closed 8 years ago

krissy commented 8 years ago

Addresses #75

:eyes: Reviewers - some indentation changes so view without whitespace diff: - https://github.com/empowerhack/DrawMyLife-Service/pull/77/files?w=1

What this does

Fixes small pagination bug which was repeating the entire table instead of its X number of rows only. Also increases the max rows to 10 from 3.

Also:

Before:

screen shot 2016-08-14 at 22 10 46

After:

screen shot 2016-08-14 at 22 11 16
krissy commented 8 years ago

🌵 Rebased on master so please hard reset if you've checked this out locally beforehand

krissy commented 8 years ago

I've added a few more changes with the feedback, specifically:

Change edit/delete access to drawings so any user from the same organisation can edit.

Hide delete/edit icons if they can't delete/edit.

Add link to View Post to thumbnail, and update Edit link to go to edit view.

Simplify status logic.

Some small copy changes.

Please re-review @stevesmith2609 @tanyapowell and will aim to merge tomorrow before usability test.

steverabino commented 8 years ago

:+1:

krissy commented 8 years ago

🌵 Rebased on master

steverabino commented 8 years ago

:+1: Have a comment about only concatenating "..." on the end of description and story if it is too long, but happy to fix that later

krissy commented 8 years ago

Ok :) yes let's address after :+1: