empowerhack / DrawMyLife-Service

API and Admin system for the Draw My Life initiative - Volunteers: check README and GitHub Projects to get started.
https://github.com/empowerhack/DrawMyLife-Service/projects
MIT License
13 stars 0 forks source link

[#53/72/74] Change hard-deletion of users to soft-deactivation, add decorators #81

Closed krissy closed 8 years ago

krissy commented 8 years ago

Addresses #53, #72 and #74

What this does

We no longer want to hard-delete users, just deactivate them, also securing the images they uploaded from being wiped. Also adds decorators for presentation logic going forward (#72).

Features

Deleted user:

screen shot 2016-08-15 at 00 28 32 screen shot 2016-08-15 at 00 28 40

Deactivate copy:

screen shot 2016-08-15 at 00 43 27

evi

steverabino commented 8 years ago

LGTM; you realise you're not actually using the support email anywhere, or is this for use later?

krissy commented 8 years ago

@stevesmith2609 Thank you! Yeah, I started building the support email code to use in Devise message for failed login. However, Devise currently makes it v complicated to use translations that have dynamic variables for their flash errors and was not worth the hack right now. :( The work had been done at least and I think the UI should definitely have a support link somewhere, so leaving it in.

steverabino commented 8 years ago

:+1: