empowerhack / DrawMyLife-Website

A website showcasing the Draw My Life initiative, partnerships and team
http://drawmylife.org/
2 stars 1 forks source link

Resolve build process #65

Closed carmat closed 7 years ago

carmat commented 7 years ago

Addresses issue: Build process

Notes for reviewers

I appreciate that there may be some things in this PR that are incorrect, covered elsewhere, or missing key elements as part of the build process. Please advise so I can be in a better place to kick-on with something a little easier to figure out :)

Cheers

What this does

Screenshots

![Before](http://url/to/img.png) ![After](http://url/to/img.png)

Current view

Current

krissy commented 7 years ago

Hey Colly! Thanks 10000x for looking into this. The problem ended up to be a little deeper into how we set up deployment for GitHub Pages. The good news is I've now merged some changes that seem to have fixed the conflicts here https://github.com/empowerhack/DrawMyLife-Website/pull/66. This means everyone should be unblocked on working on the normal tasks and getting everything building locally. If you check out master and have everything working according to the README instructions, feel free to close this PR and get stuck in one of the real tasks that are hopefully not around fixing build issues!

carmat commented 7 years ago

Help received from @krissy and @stevesmith2609 to resolve issues I've had.

Only thing remaining here is the inclusion of bundle/ in the gitignore file, which I'll add in a new releasable elsewhere.