empreinte-digitale / orejime

An easy to use consent manager that focuses on accessibility.
https://orejime.empreintedigitale.fr/
Other
155 stars 26 forks source link

SRI need crossorigin and integrity attributes #106

Closed hemodroid closed 1 month ago

hemodroid commented 1 month ago

The crossorigin and integrity attributes are note copied from original script ex:

original script <script type="opt-in" data-type="text/javascript" data-name="test-sri" data-src="https://sri.test.com/test-sri.js" crossorigin="anonymous" integrity="sha256-ABC"></script>

result script <script data-type="text/javascript" data-name="test-sri" data-src="https://sri.test.com/test-sri.js" type="text/javascript" src="https://sri.test.com/test-sri.js"></script>

felixgirault commented 1 month ago

Sorry @hemodroid, the issue was closed automatically when merging the fix. I just released a version 2.3.1, which should fix the issue. As said in the PR, this is a quick fix for the two attributes you mentionned, as a better solution is coming with version 3.