search

empreinte-digitale / orejime

An easy to use consent manager that focuses on accessibility.
https://orejime.empreintedigitale.fr/
Other
156 stars 26 forks source link

Accept All button should never be disabled #59

Open lykyd opened 3 years ago

lykyd commented 3 years ago

I think on a business matter, website owners prefer that the user choose the "Accept All" ("Tout accepter"). The fact that the "Accept all" button is disabled when all the categories of cookies are already selected is bad. It could lead the user to "Refuse all" just because he could not click on "Accept all" and did not reached for the "Save" ("Sauvegarder") button that is far at the bottom.

felixgirault commented 3 years ago

Hello

I think on a business matter, website owners prefer that the user choose the "Accept All" ("Tout accepter").

As Orejime is providing a way for users to get information and make choices, it is mainly targeted at them instead of business focused. Website owners may not appreciate it, but the point of GDPR is precisely to let the user in charge.

It could lead the user to "Refuse all" just because he could not click on "Accept all"

I don't think this could lead anyone to "Refuse all". "Accept" and "Refuse" are two explicitly opposite actions, so it sounds weird to me that anyone could use one as a fallback to the other. Maybe the problem lies in that there is no way for the user to tell why the button is disabled. We could probably make it clearer that it is because all apps are actually checked.

lykyd commented 3 years ago

Even outside of the user or business consideration, I think that it's not user-friendly to disable buttons when it is not necessary. Maybe there is another reason for disabling them that I just don't get ?

It works in both ways (accept or delete). Why shoud we prevent user to be able to click the "Delete all" and force him to click on "Save" at the bottom when all he wants is to "Delete all" ?

Probably explaining why the button are disabled will be more confusing than just letting them enabled.

Also, using the "pointer" cursor when hovering those links would be a good thing too.

felixgirault commented 3 years ago

Maybe there is another reason for disabling them that I just don't get ?

I dug up this commit https://github.com/empreinte-digitale/orejime/commit/ad7ed067b1b476f91911140ab7e09586b1b5bbea (then slightly updated https://github.com/empreinte-digitale/orejime/commit/dbfb0cebed3d3fbaf2c1723a50270331991528ef) which replaced the old confusing checkbox with two separate buttons. The disabling behavior came along with this change. I can't tell you more about it just from git history but I'll get in touch with the original author.

Would your solution be to stop disabling the buttons? (I could buy into it, I just want to be sure it's your point first)

It works in both ways (accept or delete). Why should we prevent user to be able to click the "Delete all" and force him to click on "Save" at the bottom when all he wants is to "Delete all" ?

This is where I get confused, maybe your solution would be to make these buttons actions instead of mere helpers, so they would accept/decline all and immediately close the modal?

Probably explaining why the button are disabled will be more confusing than just letting them enabled.

You're probably right :sweat_smile:

Also, using the "pointer" cursor when hovering those links would be a good thing too.

When talking about "those links", are you still referring to the accept/decline buttons? There is already a cursor pointer on them (with the current version at least https://orejime.empreintedigitale.fr/)

felixgirault commented 3 years ago

Hi @lykyd, any news regarding my previous comment?