search

empress / ember-cli-showdown

Ember component to render markdown into HTML.
https://empress.github.io/ember-cli-showdown/
MIT License
101 stars 35 forks source link

Ember 3.9 Deprecation in extensions property #74

Closed Unkrass closed 4 years ago

Unkrass commented 5 years ago

With Ember 3.9 I get the following deprecation warning:

DEPRECATION: The eos@component:markdown-to-html::ember874#extensions computed property was just overriden. This removes the computed property and replaces it with a plain value, and has been deprecated. If you want this behavior, consider defining a setter which does it manually. [deprecation id: computed-property.override] See https://emberjs.com/deprecations/v3.x#toc_computed-property-override for more details.

I believe that it would be enough to remove the computed property, since it simply returns an empty array.

ember-cli-showdown/addon/components/markdown-to-html.js, line 15: extensions: computed(function() { return []; }),

shijiezhou1 commented 5 years ago

Please fixed the extension and it is not working @gcollazo

bench-marc commented 5 years ago

https://github.com/gcollazo/ember-cli-showdown/pull/82

Unkrass commented 4 years ago

@gcollazo @jasonmit can you merge bench-marc's PR any time soon?

jasonmit commented 4 years ago

@Unkrass should be fixed in 4.5.0

Fix: https://github.com/gcollazo/ember-cli-showdown/commit/015b255fd62e81fca039f1a8ee09144a6c6803d1

Unkrass commented 4 years ago

@jasonmit much appreciated