Update LLVM compilation instructions to work on Windows
The LLVM-Wrapper abstracts away different LLVM configurations, so dynamic linking will work.
I updated the CMake in #59 to use transitive target properties, so everything will work when doing target_link_libraries(example PRIVATE nyxstone::nyxstone) (the dependency on LLVM is transitively resolved). This is generally how 'modern CMake' has worked in the past ~5 years and it simplifies things a lot.
When I have more time I will also add proper installation support to nyxstone, then people can replace add_subdirectory with find_package(nyxstone) and the same instructions will keep working.
I forgot to push a minor change to the LLVM-Wrapper (C++ standard requirement), this is not necessary for things to work but helpful in case people copy the file.
LLVM-Wrapper
abstracts away different LLVM configurations, so dynamic linking will work.target_link_libraries(example PRIVATE nyxstone::nyxstone)
(the dependency on LLVM is transitively resolved). This is generally how 'modern CMake' has worked in the past ~5 years and it simplifies things a lot.nyxstone
, then people can replaceadd_subdirectory
withfind_package(nyxstone)
and the same instructions will keep working.LLVM-Wrapper
(C++ standard requirement), this is not necessary for things to work but helpful in case people copy the file.