emptygx / pe

0 stars 0 forks source link

Recurring appointment date booking issue #7

Open emptygx opened 1 year ago

emptygx commented 1 year ago

When a recurring appointment is set at 1Y2M3D, for an appointment on the last day of February, after the appt is marked as done, the new appointment should be set for the 3rd of May, but it is set at the 1st of May instead.


video:https://raw.githubusercontent.com/emptygx/pe/main/files/a63de7b3-ccf3-4104-a02d-127e69fc95ac.mov

nus-pe-bot commented 1 year ago

Team's Response

This is intended. When a recurring appointment is set at 1Y2M3D, we add 1 year, 2 months, 3 days to the current date. So from February 28 it will be Feb 28 of the next year, then adding 2 months will yield April 28, then adding 3 days will give 1st May

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Firstly, this mode of calculation is not mentioned in the UG.

Secondly, as a user, if I have a recurring appointment on the last day of every month, I will set the recurring appointment at 1M, as there is no way else for me to set it as the last day of the month, so setting it at 1M should use the number of days in the month and offset it as such, or provide a better way of setting the frequency.

Lastly, what the team mentioned in their response does not even align with their implementation, as upon further testing, when the date of appointment is set to 31 Jan and the recurrence set to 1M, the subsequent appointments are booked on Feb 28, which follows my assumption, then on Mar 28, which follows their response, as shown in the screen recording below, which is erratic and irregular behaviour. Hence, this is a valid bug, of at least medium severity, for a very common use case that could affect patients' medical appointment dates.


video:https://raw.githubusercontent.com/emptygx/pe/main/files/f9af4b25-0e64-47c0-9ab0-3d0df7ba850f.mov