search

emqxarchive / emqx-docker

This repository is no longer maintained, please go to https://github.com/emqx/emqx-rel/tree/master/deploy/docker
Apache License 2.0
235 stars 162 forks source link

Minor fix #99

Closed spring2maz closed 5 years ago

spring2maz commented 5 years ago

There are still some issues with image tag/version. First of all, OS variable is not defined for docker.sh. Then it's questionable why it is necessary to exist. IMHO, below full image tag pattern is better than having os and or arch in the version part (i.e. after :) 

emqx/emqx.x86_64:3.0.0-$BUILD
emqx/emqx-edge.arm32v6:3.0.0-$BUILD
emqx/emqx-edge.x86_64:3.0.0-$BUILD

where BUILD should be derived from git tag in this repo. e.g. if we tag a commit v3.0.0-42 then the next should be v3.0.0-43. meaning the 43rd build for v3.0.0 emqx.