There are still some issues with image tag/version.
First of all, OS variable is not defined for docker.sh.
Then it's questionable why it is necessary to exist.
IMHO, below full image tag pattern is better than having os and or arch in the version part (i.e. after :)
where BUILD should be derived from git tag in this repo.
e.g. if we tag a commit v3.0.0-42 then the next should be v3.0.0-43.
meaning the 43rd build for v3.0.0 emqx.
There are still some issues with image tag/version. First of all,
OS
variable is not defined for docker.sh. Then it's questionable why it is necessary to exist. IMHO, below full image tag pattern is better than having os and or arch in the version part (i.e. after:
)where
BUILD
should be derived from git tag in this repo. e.g. if we tag a commit v3.0.0-42 then the next should be v3.0.0-43. meaning the 43rd build for v3.0.0 emqx.