Mismanaged Code; JOST Build Fails

[GoogleCodeExporter]

First a patch for the non-troublesome stuff:

Index: apps/jost/src/model/plugins/midiplugins/SequenceComponent.h
===================================================================
--- apps/jost/src/model/plugins/midiplugins/SequenceComponent.h (revision 
133)
+++ apps/jost/src/model/plugins/midiplugins/SequenceComponent.h (working 
copy)
@@ -32,7 +32,7 @@
 #include "../../../Config.h"
 #include "../../../HostFilterComponent.h"
 #include "MidiSequencePlugin.h"
-#include "PluginEditorComponent.h"
+#include "../../../ui/plugins/PluginEditorComponent.h"

 class NoteEditComponent;
 class AutomationEditComponent;
Index: apps/jost/src/model/plugins/midiplugins/MidiSequencePluginBase.h
===================================================================
--- apps/jost/src/model/plugins/midiplugins/MidiSequencePluginBase.h    
(revision 133)
+++ apps/jost/src/model/plugins/midiplugins/MidiSequencePluginBase.h    
(working copy)
@@ -29,7 +29,7 @@
 #ifndef __JUCETICE_JOSTMIDISEQUENCEPLUGIN_HEADER__
 #define __JUCETICE_JOSTMIDISEQUENCEPLUGIN_HEADER__

-#include "BasePlugin.h"
+#include "../../BasePlugin.h"

 //=========================================================================
=====

And then the troublesome one:

../../src/model/plugins/midiplugins/MidiSequencePluginBase.cpp:48: error: 
declaration of ‘~MidiSequencePlugin’ as member of 
‘MidiSequencePluginBase’

And lookin at line 48:

MidiSequencePluginBase::~MidiSequencePlugin ()
{
    deleteAndZero (midiSequence);
}

I'm on GCC 4.4, but this does not look like a documented porting failure, 
so GCC version shouldn't be an issue here. Furthermore, we should be 
compatible with the latest GCC in the first place.

Original issue reported on code.google.com by schivmei...@gmail.com on 23 Oct 2009 at 8:56

[GoogleCodeExporter]

Thank you. Those path errors were known (at least to me).
For the troublesome one:
It's just a destructor mismatch. Substitute
MidiSequencePluginBase::~MidiSequencePlugin ()
with
MidiSequencePluginBase::~MidiSequencePluginBase ()

Original comment by spanka...@gmail.com on 24 Oct 2009 at 9:24

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Original comment by spanka...@gmail.com on 24 Oct 2009 at 9:28

• Changed state: Accepted

[GoogleCodeExporter]

And then:

../../src/model/plugins/midiplugins/MidiSequencePlugin.cpp: In member function 
‘virtual void MidiSequencePlugin::processBlock(juce::AudioSampleBuffer&, 
juce::MidiBuffer&)’:                                
../../src/model/plugins/midiplugins/MidiSequencePlugin.cpp:236: error: no 
matching 
function for call to ‘find(__gnu_cxx::__normal_iterator<int*, 
std::vector<int, 
std::allocator<int> > >, __gnu_cxx::__normal_iterator<int*, std::vector<int, 
std::allocator<int> > >, int)’   
../../src/model/plugins/midiplugins/MidiSequencePlugin.cpp:277: error: expected 
primary-expression before ‘}’ token                     
../../src/model/plugins/midiplugins/MidiSequencePlugin.cpp:277: error: expected 
‘;’ 
before ‘}’ token                                    
make[1]: *** 
[../../../../bin/intermediate_linux/jostRelease/MidiSequencePlugin.o] 
Error 1                                              
make: *** [jost] Error 2

I foresee more of such issues :)

Original comment by schivmei...@gmail.com on 24 Oct 2009 at 12:11

[GoogleCodeExporter]

That also is known (to me!).
Just comment out these two lines:

if (midiMessage->isController() && (std::find(doneTheseControllers.begin(),
doneTheseControllers.end(), midiMessage->getControllerNumber()) ==
doneTheseControllers.end()))
lastCtrlEvent = midiMessage;

BECOMES

/*if (midiMessage->isController() && (std::find(doneTheseControllers.begin(),
doneTheseControllers.end(), midiMessage->getControllerNumber()) ==
doneTheseControllers.end()))
lastCtrlEvent = midiMessage;*/

Sorry for this kind of issues, haszari is working on some stuff which is not yet
complete!

Original comment by spanka...@gmail.com on 24 Oct 2009 at 5:05

[GoogleCodeExporter]

Heh, nevermind. The entire tree has to be sorted out:

../../src/model/plugins/midiplugins/MidiSequencePlugin.cpp: In member function 
‘virtual void MidiSequencePlugin::processBlock(juce::AudioSampleBuffer&, 
juce::MidiBuffer&)’:                                
../../src/model/plugins/midiplugins/MidiSequencePlugin.cpp:277: error: expected 
primary-expression before ‘}’ token                     
../../src/model/plugins/midiplugins/MidiSequencePlugin.cpp:277: error: expected 
‘;’ 
before ‘}’ token

And there will be more after this one is fixed, etc.

What would be good is a separate branch for development, eg. "ongoing" and push 
periodically to trunk. Or rather, a separate branch to push _working_ (not 
broken) 
changes, maybe to something like "branches/current", from trunk.

This would then allow users to build bleeding versions (not necessary stable, 
but at 
the same time not broken build tree) when the latest (development) release 
version 
cannot be built (eg. 0.5.4 broken due to GCC 4.4). I have successfully patched 
0.4.6, 
but that was because the porting was trivial.

Original comment by schivmei...@gmail.com on 25 Oct 2009 at 9:51

Attachments:

• 0001-Fix-JOST-0.4.6-building-with-GCC-4.4.patch

[GoogleCodeExporter]

Please wait next revision. We're very close to release a bublic beta, but all 
fixes
are in our hard disks. 
What OS are you on?
Windows project is very different now (also from revision 133).

Original comment by spanka...@gmail.com on 25 Oct 2009 at 10:14

[GoogleCodeExporter]

That's good news :)

Nope, Linux.

Original comment by schivmei...@gmail.com on 25 Oct 2009 at 10:19

[GoogleCodeExporter]

Everything should be up again and working.

Original comment by kunitoki on 10 Nov 2009 at 10:02

• Changed state: Fixed