search

emreakay / CodeIgniter-Aauth

Authorization, Authentication and User Management library for Codeigniter 2.x and 3.x to make easy user management and permission operations
http://emreakay.com
GNU Lesser General Public License v3.0
393 stars 234 forks source link

No transaction-handling #225

Closed chland closed 5 years ago

chland commented 6 years ago

Right now, the library isn't using transaction-handling. IMHO it would be a good idea to add it to all functions where multiple updates/deletes are executed to prevent any problems if the db-server dies halfway through deleting stuff. For example in delete_user(), delete_group() or delete_perm(), multiple delete-queries are executed.

I started to add some basic transaction-handling to the code and can create a PR from my changes later today when i'm done.

REJack commented 6 years ago

That's a great idea and your changes looks good and works.

REJack commented 5 years ago

Issue closed