search

emreeren / SambaPOS-3

Touch Screen Restaurant POS
sambapos.com
469 stars 413 forks source link

Selected Items Issue #359

Closed shuxingliu closed 11 years ago

shuxingliu commented 11 years ago

1) Select Parts of ordered Items in Pos screen p1

2) click "void" button p2

It is a bug. too obviously. :)

emreeren commented 11 years ago

Can you try it with https://github.com/emreeren/SambaPOS-3/releases/tag/V3.0.25-Beta ?

shuxingliu commented 11 years ago

Hi, Emree. I have tested with 3.0.25-Beta. The result is same. 1) Select Parts of ordered Items in Pos screen p1 2)click "void" button ![Uploading p2.png . . .]()

shuxingliu commented 11 years ago

p2

emreeren commented 11 years ago

Fixed, thanks.

JohnSCS commented 11 years ago

I have just tested with 3.0.26 Beta. I think the logic is back to front for Voiding an item. If you have 4 items, and only want 3, you select the item, hit minus (-) to show 3, but when you click Void, it voids 3 items not 1 as expected.

emreeren commented 11 years ago

I don't think there is a single logic there. If we think a different case logic would seem OK. For example 5 coffee ordered, 2 customers changed their mind and ordered tea. So I'll void 2 coffee and add 2 tea. If you think the number in parenthesis as "Selected Quantity" it would make sense for all cases.

JohnSCS commented 11 years ago

Your right that there is no single logic, but it doesn't make sense because you are reversing the default function of + - By default the + - change the ordered quantity of the item, which to me means if someone says they want 3 coffees instead of 4, you drop the order to 3 and press void to remove 1. If you haven't closed the order yet, then the + - change the quantity ordered. It's a reverse in logic.

emreeren commented 11 years ago

But John order is in locked state and we can't change quantity like we do on new orders. If clicking (-) and clicking void should mean "quantity decrease" clicking (+) should have different meaning. By clicking (+) and (-) buttons we are not changing order quantity. We are setting how many items we'll void (or gift, move, tag, etc).

Void is not the only example. Some people thinks our whole logic is reversed. For example they thinks we should click "Change Price" button first and type a price, click "Discount" button first and type a rate or click "Void" button first and type void quantity. In the other words they want to choose a function first and enter the amount. Yes our logic is reversed for a reason so you choose void quantity first and click void button like you type a discount amount first and click discount button. I think our logic here matches with other SambaPOS functions but maybe using (+) (-) labels for these buttons is the problem. While programming our first versions we really thought a lot about it but couldn't find a better idea. For this reason we put them in parenthesis.

JohnSCS commented 11 years ago

I understand what your saying. And when you look at Gift, Discount, etc then it does make more sense.

emreeren commented 11 years ago

Yes when thought with other features it makes sense to experienced sambapos users but when thought twice your point is true from the sight of the new user so I'm open to suggestions to improve that without changing logic a lot.