search

emrepun / StickyTabBarViewController

Sticky and Collapsible View on top of tab bar
MIT License
150 stars 15 forks source link

Instead of setting constraints to child view controllers view, just confine it within parents bounds #21

Closed emrepun closed 4 years ago

emrepun commented 4 years ago

Description

While investigating, I found out that there were issues for different iPhone simulators as well, this should fix for all device types now.

Ideally a child view controller will have its own constraints and setting constraints to expandable's view directly was causing problems of conflicting constraints. This fix doesn't care about constraining child view to the parent one but rather makes your it lives within the bounds of it.

How it looks on iPad: Collapsed: Simulator Screen Shot - iPad Pro (12 9-inch) (4th generation) - 2020-05-29 at 21 29 12

Expanded: Simulator Screen Shot - iPad Pro (12 9-inch) (4th generation) - 2020-05-29 at 21 29 14

Closes #18

Definition of Done

emrepun commented 4 years ago

I increased version to 0.0.5 but not sure if I should make a release and update readme. It is kind of a critical fix but, pod is not mature enough to be used yet anyways, what do you think? @Thurman1776- 🤔

Thurman1776- commented 4 years ago

I increased version to 0.0.5 but not sure if I should make a release and update readme. It is kind of a critical fix but, pod is not mature enough to be used yet anyways, what do you think?

Didn't we agree on publishing this pod as a stable version once this issue was fixed? 🤔 Can't really recall as it is been a while 😬 @emrepun