emrikol / focus

File-based Object Cache is Utterly Slow: An Object Caching Dropin for WordPress that uses the local file system
https://wordpress.org/plugins/focus-object-cache/
GNU General Public License v3.0
6 stars 2 forks source link

Wrong check for nonce and action in FOCUS_Cache:: render_admin_page #2

Closed david-binda closed 7 years ago

david-binda commented 7 years ago

The $nonce and $action variables are always set, thus checking for isset() in https://github.com/emrikol/FOCUS/blob/master/focus-cache.php#L129 is redundant and actually does not do what you might think it's doing.

Strict comparison agains false might be better check in there.