Handle extern_weak functions

emscripten-core / emscripten-fastcomp

LLVM plus Emscripten's asm.js backend

Other

182 stars 111 forks source link

Handle extern_weak functions #248

Closed kripken closed 5 years ago

kripken commented 5 years ago

If we are done linking, then they should be resolved to null. (Before this PR, they'd get a function index assigned, so they were non-null, and comparisons to null were incorrect.)

kripken commented 5 years ago

Passes all tests for me locally, merging.

dschuff commented 5 years ago

We should go ahead and tag a minor release for this.

kripken commented 5 years ago

I tagged 1.38.22 now.