search

emscripten-core / emscripten

Emscripten: An LLVM-to-WebAssembly Compiler
Other
25.74k stars 3.3k forks source link

Find a solution for Firefox GL testing #14401

Open sbc100 opened 3 years ago

sbc100 commented 3 years ago

It got the point where only 1 in 5 or so runs were passing so this was effecting all PRs.

The temporary workaround was to pin firefox to beta rather than dev in #14392.

Sadly I don't have more for info what kind of failure is occuring and this will probably come back to bite when beta gets updated in a few days/weeks.

An example of failing test run is here: https://app.circleci.com/pipelines/github/emscripten-core/emscripten/13810/workflows/01da6e69-67bb-4d40-9ab4-d956eb417aae/jobs/432581

It ends with skipped 'too many unresponsive tests, skipping browser launch - check your setup!' which I think means the browser crashed or at least locked up.

kripken commented 3 years ago

After that PR landed, we run Firefox in headless mode, which is simpler and stable but means we must avoid GL testing.

Discussion on Twitter suggests maybe using xvfb-run. It looks like you tried that @sbc100 in https://github.com/emscripten-core/emscripten/pull/7020 but had to give up. Perhaps today it can work though?

kripken commented 3 years ago

Another Twitter mention of success using xvfb: https://github.com/petersalomonsen/javascriptmusic/blob/master/.github/workflows/main.yml#L36

(thread: https://twitter.com/kripken/status/1403389061423714304)