emscripten-core / emscripten

Emscripten: An LLVM-to-WebAssembly Compiler
Other
25.45k stars 3.25k forks source link

Release changelog not updating #17364

Open connorjclark opened 2 years ago

connorjclark commented 2 years ago

Two places I'd expect to see details on the latest emscripten releases, but are stale:

1- https://emscripten.org/docs/introducing_emscripten/release_notes.html (showing up to 3.1.9) 2- https://github.com/emscripten-core/emscripten/releases (only shows 3.0, maybe just delete if GH won't be used to track releases?)

According to ChangeLog.md 3.1.15 is out, but I thought 3.1.9 was the latest since I only checked the docs 😄 Is there some existing channel or mailing group I can subscribe to for release announcements?

sbc100 commented 2 years ago
  1. Yes our documentation doesn't get automatically updated. I wish that it did. @kripken is that worth investing in do you think?
  2. Deleted.
kripken commented 2 years ago

I think it could make sense to automate. I don't have a good idea of how to do that though. In particular we've had issues in the past with rendering failing on stuff like the search page (which uses JS) - to avoid that I do a quick manual check myself.

I updated it manually now. I didrun into a python error

ImportError: cannot import name 'environmentfilter' from 'jinja2'

That looks like https://github.com/readthedocs/readthedocs.org/issues/9038 which I tried to apply the workaround of by doing pip install jinja2==3.0. However then I get

Warning, treated as error:
node class 'meta' is already registered, its visitors will be overridden
make: *** [Makefile:65: html] Error 2

Which seems to be https://github.com/sphinx-doc/sphinx/issues/9841. To work around that I temporarily removed -W from our makefile in order to build. I'm not very familiar with the python module ecosystem so perhaps there is a better way here? Or is there something we need to fix?

sbc100 commented 2 years ago

I don't see any warnings. Do you have the correct sphinx version installed (v2.4.4)? Did you run pip install -r requirements-dev.txt?

kripken commented 2 years ago

I do have 2.4.4. I thought I ran that pip command before... but running it now seems to fix things, thanks.