emscripten-core / emscripten

Emscripten: An LLVM-to-WebAssembly Compiler
Other
25.72k stars 3.3k forks source link

Glfw not propagating window resize events #20830

Open pierricgimmig opened 10 months ago

pierricgimmig commented 10 months ago

Window resize events are not piped to glfwSetFramebufferSizeCallback nor glfwSetWindowSizeCallback making the application unaware that the browser window was dynamically resized.

Adding this code to library_glfw fixes the issue for me:

window.addEventListener("resize", () => {
  GLFW.onCanvasResize(window.innerWidth, window.innerHeight);
});

Version of emscripten/emsdk:

emcc (Emscripten gcc/clang-like replacement + linker emulating GNU ld) 3.1.47 (431685f05c67f0424c11473cc16798b9587bb536) clang version 18.0.0 (https://github.com/llvm/llvm-project 21030b9ab4487d845e29792063f5666d8c4b8e09) Target: wasm32-unknown-emscripten Thread model: posix InstalledDir: C:\git\emsdk\upstream\bin

pierricgimmig commented 10 months ago

https://github.com/emscripten-core/emscripten/pull/20831

pierricgimmig commented 10 months ago

This is by design, see comments in https://github.com/emscripten-core/emscripten/pull/20831 for more info