emscripten-core / emscripten

Emscripten: An LLVM-to-WebAssembly Compiler
Other
25.67k stars 3.29k forks source link

Revert "Bump min node version to 18.20.3 (#22010)" #22023

Closed dschuff closed 4 months ago

dschuff commented 4 months ago

This is mostly a revert of commit 27b30507ffd4141b57a6bf564280b78960ff617b.

It reverts the min node version in emscripten, but keeps the CircleCI configuration to test with node 18.

This is a temporary workaround for #22022

dschuff commented 4 months ago

I decided to go back and keep the CI update; i.e. Circle will stay no node 18, so we can keep depending on it in tests. WDYT?

sbc100 commented 4 months ago

I decided to go back and keep the CI update; i.e. Circle will stay no node 18, so we can keep depending on it in tests. WDYT?

lgtm