emscripten-core / emscripten

Emscripten: An LLVM-to-WebAssembly Compiler
Other
25.36k stars 3.25k forks source link

Use spread operator over concat in internal JS code. NFC #22083

Closed sbc100 closed 3 weeks ago

msqr1 commented 2 weeks ago

Isn't the spread operator super slow when the input size is large? Or we will practically never have big number of elements?

sbc100 commented 2 weeks ago

Isn't the spread operator super slow when the input size is large? Or we will practically never have big number of elements?

I think all the uses of the spread operator here is with arrays that are known to be very small.