emscripten-core / emscripten

Emscripten: An LLVM-to-WebAssembly Compiler
Other
25.35k stars 3.25k forks source link

Update npm dependencies. NFC #22122

Closed sbc100 closed 6 days ago

sbc100 commented 1 week ago

I used npm-check-update to generate this PR:

  1. npm install --global npm-check-updates
  2. ncu -u
  3. npm install
sbc100 commented 1 week ago

I held back closure-compiler and eslint which both seemed to have some issues on upgrade.

sbc100 commented 1 week ago

@brendandahl could you take a look at the test failure here? It looks like one of the generated typescript signatures changed:

--- /root/project/test/other/test_emit_tsd.d.ts
+++ /root/project/test/other/test_emit_tsd.d.ts.new
@@ -9,7 +9,7 @@
      * @param {number=} maxBytesToRead
      * @return {string}
      */
-    function UTF8ArrayToString(heapOrArray: any, idx: number, maxBytesToRead?: number): string;
+    function UTF8ArrayToString(heapOrArray: any, idx: number, maxBytesToRead?: number | undefined): string;
     let wasmTable: WebAssembly.Table;
     let HEAPF32: any;
     let HEAPF64: any;

I can't tell if that is for the better or worse though? Isn't | undefined redundant in the face of ?

brendandahl commented 6 days ago

I would think those would be the same. I can do a bisect and see when it changed, but I don't think you need to block this PR on it.