search

emscripten-core / emscripten

Emscripten: An LLVM-to-WebAssembly Compiler
Other
25.91k stars 3.32k forks source link

MIN_NODE_VERSION: mismatch between settings.js and changelog #23044

Closed VirtualTim closed 2 days ago

VirtualTim commented 2 days ago

Default MIN_NODE_VERSION does not match the minimum version reported in the release notes.

In settings.js we have: https://github.com/emscripten-core/emscripten/blob/06cebfca51f908d3bc6897113330e45a77010db2/src/settings.js#L1930-L1931

In the release notes we have (3.1.48): https://github.com/emscripten-core/emscripten/blob/06cebfca51f908d3bc6897113330e45a77010db2/ChangeLog.md?plain=1#L420-L422 and (3.1.42): https://github.com/emscripten-core/emscripten/blob/06cebfca51f908d3bc6897113330e45a77010db2/ChangeLog.md?plain=1#L531-L534

I'm assuming that MIN_NODE_VERSION in settings.js should just be changed to 162000, and the comment updated.

VirtualTim commented 2 days ago

Actually, re-reading things again, I think it might be correct as is. One node is the internal NodsJS Emscripten uses in it's build process, and the other is the runtime target.