search

emscripten-core / emscripten

Emscripten: An LLVM-to-WebAssembly Compiler
Other
25.92k stars 3.32k forks source link

[emmalloc] Fix verbose output #23069

Open kleisauke opened 16 hours ago

kleisauke commented 16 hours ago

toString() is undeclared.

Fixes a regression introduced in commit 04a0cad.

kleisauke commented 16 hours ago

Details:

building:ERROR: Closure compiler run failed:

building:ERROR: /tmp/emscripten_temp_50snxhja/vips-es6.jso3.js:757:85: ERROR - [JSC_UNDEFINED_VARIABLE] variable toString is undeclared
  757|     out("aligned_realloc(ptr=" + ptrToString($0) + ", alignment=" + $1 + ", size=" + toString(Number($2)));
                                                                                            ^^^^^^^^

1 error(s), 0 warning(s)
sbc100 commented 6 hours ago

Are we missing a test for -sMALLOC=emmalloc-verbose?

kripken commented 5 hours ago

Yes, looks like that isn't covered by any existing test. Might be worth adding, but it is a setting for internal debugging.