search

emscripten-core / emscripten

Emscripten: An LLVM-to-WebAssembly Compiler
Other
25.42k stars 3.26k forks source link

Cannot override SDL2_net with EMCC_LOCAL_PORTS #8466

Open fallenoak opened 5 years ago

fallenoak commented 5 years ago

If I set the EMCC_LOCAL_PORTS environment variable to sdl2_net=/path/to/dir, I see the following error:

system_libs:ERROR: port sdl2_net lacks .SUBDIR attribute, which we need in order to override it locally, please update it

Is this because SUBDIR is missing in tools/ports/sdl2_net.py?

What's necessary to permit the use of EMCC_LOCAL_PORTS for a given library?

kripken commented 5 years ago

Yeah, we need to define SUBDIR in ports for this to work with them. See how the sdl2.py does it - should be straightforward to add I think.

quantum5 commented 5 years ago

A quick inspection showed that only sdl2.py has the SUBDIR attribute. Perhaps we should think of a better way to implement this feature that doesn't need to set SUBDIR on all ports?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 7 days. Feel free to re-open at any time if this issue is still relevant.

SkyLeite commented 1 year ago

This is still an issue