search

emscripten-core / emsdk

Emscripten SDK
http://emscripten.org
Other
3.02k stars 688 forks source link

Node configuration potentially breaking builds #1242

Closed jeswr closed 1 year ago

jeswr commented 1 year ago

In swipl-wasm we have this dockerfile extending the emsdk docker image to build the code for our package.

We upgraded to emsdk v3.1.42 without any problems. As a follow up I tried to remove our manual override setting the node version to node 16; as theoretically this is the default in emsdk v3.1.42. However this broke our build with the error wasm-ld: error: src/libswipl.a(pl-alloc.c.o): undefined symbol: PL_dlsym.

Pull request attempting to remove node 16 override: https://github.com/SWI-Prolog/npm-swipl-wasm/pull/246. Build failure: https://github.com/SWI-Prolog/npm-swipl-wasm/actions/runs/5368721408/jobs/9739613650?pr=246

Any ideas on what could be causing this?

jeswr commented 1 year ago

Ignore - I forgot to remove the DNODE_JS_EXECUTABLE parameter.