search

emscripten-core / emsdk

Emscripten SDK
http://emscripten.org
Other
2.96k stars 676 forks source link

Switch to .xz by default for SDK downloads #1281

Closed sbc100 closed 11 months ago

sbc100 commented 11 months ago

This is a bit of a hack but I can't think of another way to do it. Basically when downloading SDKs, we first try the new .xz extension. If that fails, we fall back to the old .tbz2. Both these first two download attempts we run in "silent" mode. If both of them fail we re-run the original request in non-silent mode so that the error message will always contain the original .xz extension.

See #1235

sbc100 commented 11 months ago

I manually uploaded an .xz version the 3.1.46 linux binaries so that test-linux bot here will use that version over the tbz2

sbc100 commented 11 months ago

You can see it download in the .xz file here: https://app.circleci.com/pipelines/github/emscripten-core/emsdk/2059/workflows/2832797a-6de0-4179-88ba-baff916ad11f/jobs/12259?invite=true#step-105-7623_256

dschuff commented 11 months ago

Relatedly, I wonder if we can do any better on Windows. I don't know of any other archive formats natively supported by Windows, do you? I wonder if it's worth bundling something with emsdk, it makes a pretty big compression difference.

dschuff commented 11 months ago

(oh, maybe you should mention that this only affects Mac and Linux. If we could do something for windows too, it could still have a big impact).

sbc100 commented 11 months ago

(oh, maybe you should mention that this only affects Mac and Linux. If we could do something for windows too, it could still have a big impact).

Mention where?

dschuff commented 11 months ago

I guess I meant in the commit description; but as mentioned this probably warrants a changelog entry and maybe an announcement to emscripten-discuss (the fact that most users need to update emsdk to see new versions makes this less of a big deal I guess, but still maybe worth doing).

sbc100 commented 11 months ago

Will do