emscripten-core / emsdk

Emscripten SDK
http://emscripten.org
Other
2.91k stars 660 forks source link

emsdk_env.fish works but shows errors #1299

Open RReverser opened 7 months ago

RReverser commented 7 months ago

Using emsdk_env.fish has been showing error in console for a while. I never looked before what was it because there is a lot of noise in the output due to long PATH variable and because the environment is still set up correctly - but it seems to be due to usage of unset command which doesn't exist in fish:

> source ~/emsdk/emsdk_env.fish
Setting up EMSDK environment (suppress these messages with EMSDK_QUIET=1)
Adding directories to PATH:
PATH += /home/rreverser/emsdk
PATH += /home/rreverser/emsdk/upstream/emscripten

Setting environment variables:
PATH =  <...>
EMSDK = /home/rreverser/emsdk
EMSDK_NODE = /home/rreverser/emsdk/node/16.20.0_64bit/bin/node
Clearing existing environment variable: EMSDK_PATH
unset: command not found
~/emsdk/emsdk_env.fish (line 1): 
export PATH="<...>"; unset EMSDK_PATH;
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    ^~~~^
from sourcing file ~/emsdk/emsdk_env.fish
sbc100 commented 7 months ago

Support for these non-standard shells is currently only best effort. Patches most welcome, as would some more testing.

RReverser commented 7 months ago

Ah okay, didn't know. For now this is just a minor inconvenience, as long as it works, it's fine.

sbc100 commented 7 months ago

It sounds like it doesn't work though, no?

RReverser commented 7 months ago

No, it works - I've been using fish for years and seen this error for a while but because it was somewhere in a long text, I just ignored it. As mentioned in issue description, environment is set up successfully anyway, so it's really more of a warning for now.