search

emscripten-core / emsdk

Emscripten SDK
http://emscripten.org
Other
2.96k stars 676 forks source link

Please bump Node version on emscripten/emsdk #1303

Closed skhaz closed 9 months ago

skhaz commented 9 months ago

Could it be possible to bump the Node version to the current LTS? The Docker image contains version 12, which is quite old.

sbc100 commented 9 months ago

Which docker images contains node 12? IIRC we updates for node 16 recently. See #1232.

Regarding updated from 16 to 18 (which is currently LTS) that has beed discussed at length in other issues such as #1173 and #1284. Since we landed #1189, the version of node used internally with emsdk should have less impact (since it not longer adds node to the path if there already exists one).

skhaz commented 9 months ago

I have found Node 16 (not 12) on /emsdk/node/16.20.0_64bit/bin in emscripten/emsdk:3.1.49

sbc100 commented 9 months ago

Do you need run node within the emsdk docker container? Is node 16 sufficient for your purposes?

skhaz commented 9 months ago

Yes, that's more than enough, I was using Node to run WebAssembly, but I changed my mind and will execute the WebAssembly with wasmtime because I have more control (I was using emscripten as base, to run a simple script in JavaScript).

Thank you!