search

emscripten-core / emsdk

Emscripten SDK
http://emscripten.org
Other
2.92k stars 662 forks source link

Only pass -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON when building llvm. NFC #1334

Closed sbc100 closed 5 months ago

sbc100 commented 5 months ago

LGTM but is this still needed? LLVM has required a C++17 toolchain for a long time, and I would be surprised if it builds with a really old toolchain

I don't use this code path enough to know.. so for now I'll just land this as is.