search

emscripten-core / emsdk

Emscripten SDK
http://emscripten.org
Other
3.05k stars 697 forks source link

What is the .pth file removal step? #1466

Open juj opened 1 month ago

juj commented 1 month ago

https://github.com/emscripten-core/emsdk/blob/8e661c80d4696d50459afb8e47ca0eb521cb758d/scripts/update_python.py#L14

says that a .pth file is being removed during update_python.py run.

I can't find a .pth file being deleted anywhere, and I wonder if that is something leftover?

sbc100 commented 1 month ago

I think those instruction should have been updated in #1001 when I switched from the "embedded" windows dist to the nuget version. I don't think that step is needed anymore.

juj commented 1 month ago

Gotcha, I'll clean up that comment.

I do see there is a Lib\site-packages\pywin32.pth that does get added after I do pip install pywin32. I wonder if I should delete that path file, or keep it around?

juj commented 1 month ago

hmm, I'll keep that around for now, we can see if it will cause issues in future. (that python "notabug" issue is a bit weird to read)