search

emscripten-core / emsdk

Emscripten SDK
http://emscripten.org
Other
3.02k stars 690 forks source link

[Question] Why use JAVA_HOME instead of EMSDK_JAVA_HOME? #1483

Open D7x7z49 opened 6 days ago

D7x7z49 commented 6 days ago

When running ./emsdk activate latest, I noticed the environment variables EMSDK_NODE and EMSDK_PYTHON. However, for Java, the variable used is JAVA_HOME instead of EMSDK_JAVA_HOME. Why is this the case?

sbc100 commented 5 days ago

emsdk doesn't use java for anything anymore so these should not be needed.

sbc100 commented 5 days ago

Sorry I take that back, it looks like we do still install java on with the windows version of the SDK. I have PR up to remove it: https://github.com/emscripten-core/emsdk/pull/1324

I think the reason JAVA_HOME was used is because that is the standard environment variable used by java itself so this makes things just work. It was probably not most hermetic way to embed java since it means the whole system would then use the emsdk version of java.