search

emscripten-forge / recipes

Recipes to build the packages for the emscripten-forge distribution
BSD 3-Clause "New" or "Revised" License
52 stars 40 forks source link

Add Geos #1128

Closed KGB99 closed 1 week ago

KGB99 commented 2 weeks ago

This seems to be a longer existing problem in emscripten: https://github.com/emscripten-core/emscripten/issues/22005 https://github.com/emscripten-core/emscripten/pull/11087 https://github.com/Keno/julia-wasm/issues/27

If cmake is executed with -DBUILD_TESTING=OFF the build seems to succeed, however im not sure how wise it is to ignore all tests.

wolfv commented 1 week ago

Maybe you can find another way to test this? Or remove tests that make the build fail?

KGB99 commented 1 week ago

I started working on a patch where i just remove the tests that fail. Should be working soon hopefully :)

wolfv commented 1 week ago

Looks good to me although I couldn't really see if the tests are executed or not.

KGB99 commented 1 week ago

The tests indeed did not run before. I tried a lot of things in the recipe such as:

tests:
  - script:
      - node bin/test_geos_unit.js
    requirements:
      build:
        - nodejs
    files:
      source:
        - tests/
        - bin/test_geos_unit.js

However I constantly get file not found errors regarding bin/test_geos_unit.js. I think there is something im not understanding right. I will add some existence tests for now.

wolfv commented 1 week ago

Hey @KGB99 - that's because the tests are not installed into the final package. You would have to execute them as part of your build script.

You might be able to invoke them with CMake / ctest.