search

emscripten-forge / recipes

Recipes to build the packages for the emscripten-forge distribution
BSD 3-Clause "New" or "Revised" License
52 stars 40 forks source link

Fix pydantic-core package name #1156

Closed martinRenou closed 5 days ago

martinRenou commented 6 days ago

To match the name of the package on conda-forge https://github.com/conda-forge/pydantic-core-feedstock/blob/main/recipe/meta.yaml#L4

martinRenou commented 6 days ago

@DerThorsten it seems the test file is not found anymore after the rename:

 │ │ Finding all test files in the current directory
 │ │ Test files found:
 │ │ []

Do you have a clue what could be the issue?

DerThorsten commented 6 days ago

I am investigating...

martinRenou commented 6 days ago

the weird thing is that the pydantic-core rebuild I triggered this morning passed just fine

DerThorsten commented 6 days ago

this is super strange,...

DerThorsten commented 6 days ago

there was a rattler build release 20h ago...not sure if this means something ;)

DerThorsten commented 6 days ago

this build uses rattler-build 0.18, while the last one where it passed I could find was using 0.16

martinRenou commented 6 days ago

Thanks for investigating @DerThorsten !

I'm happy with merging this if you don't mind having the pin on rattlerbuild for now

DerThorsten commented 6 days ago

I want to test with one more rattler-build version, then we can just merge it

DerThorsten commented 6 days ago

@martinRenou so on quetz this will appear as a "new" package with the new name, unrelated to the old one right?

martinRenou commented 5 days ago

Yes that's fine, we could remove any trace of pydantic_core there, but if someone relies on it let's keep it. I guess that would be harmless.