emscripten-forge / recipes

Recipes to build the packages for the emscripten-forge distribution
BSD 3-Clause "New" or "Revised" License
56 stars 49 forks source link

Emscripten Package Issue #1246

Closed zachcp closed 2 months ago

zachcp commented 3 months ago

I was following the instructions' on @wolfv 's great post and hit the following issue:

pixi run build-emscripten-wasm32-pkg  ./recipes/recipes_emscripten/qhull
# Cannot solve the request because of: No candidates were found for emscripten_emscripten-wasm32 3.1.45.*.

image

image

zachcp commented 3 months ago

Looks like theres a pixi init that is needed.

zachcp commented 3 months ago

Confirming that once pixi init is done, I can build ( or at least the build is in progress )

zachcp commented 3 months ago
# https://emscripten-forge.org/development/local_builds/
# this only needs to be done once
pixi run setup

# this builds the package
pixi run build-emscripten-wasm32-pkg recipes/recipes_emscripten/regex
zachcp commented 3 months ago

looks like the emscripten version is newer than the output. Seems that updating this version in the conda_build_config.yaml yields progress. Updating that allows the builds to proceed.

c_compiler_version:
  - if: emscripten
    then:
      - 3.1.58    // <---- was 3.1.45
zachcp commented 3 months ago

Aaaaand built! Great!

zachcp commented 3 months ago

Looks like emscripten is in the processs of being upgraded. Just bad timing on my part.

DerThorsten commented 3 months ago

@zachcp actually the update to emscripten 3.1.58 should not yet be visible to users. There was a tiny problem that the local builds of the compiler package where already using 3.1.58 (the version in the recipe was already the new one, I change the version in the recipe back to 3.1.45, now local builds should work as expected)

DerThorsten commented 3 months ago

@wolfv we could prevent these issues by also uploading the compiler packages for osx-arm64.

wolfv commented 3 months ago

Yes, it should be quite straightforward to build them in CI (especially since Github actions has the osx-arm64 runners these days).

DerThorsten commented 3 months ago

Yes, it should be quite straightforward to build them in CI (especially since Github actions has the osx-arm64 runners these days)

we should run this workflow also for mac https://github.com/emscripten-forge/recipes/blob/main/.github/workflows/build_recipes.yaml but only build the packages from the 'recipes/recipes' dir (and not 'recipes/recipes_emscrtipten' dir) and then only upload the packages if they are for osx-arm64 (there are also noarch pkgs in recipes/recipess)