search

emscripten-ports / FreeType

6 stars 6 forks source link

Updating to v2.10.4 #5

Open HCLJason opened 3 years ago

HCLJason commented 3 years ago

Pulled updated source from freetype.org

This doesn't compile as a port without some modification to the entry in tools/ports. I have an incoming PR for that file as well.

kripken commented 3 years ago

Does this repo, before your PR, have local changes compared to upstream? If not, perhaps as discussed in the other ports we should first switch to upstream?

HCLJason commented 3 years ago

It does not.

I can make the change to switch to upstream in the emscripten repo's freetype.py file.

kripken commented 3 years ago

Thanks @HCLJason - sorry for the back and forth on the different repos, but I think we have a clear plan now in all of them. That is, if they have no changes from their upstreams, and the upstreams are on github or somewhere else reliable, we should switch to use the upstreams first in emscripten (then remove the repos in ports).

Actually, looking at freetype, it looks like their upstream is on sourceforge. But they have an official mirror at https://github.com/freetype/freetype which we can use.

HinTak commented 2 years ago

@kripken no, the official place for freetype until recently was GNU savannah. It has moved to gitlab (like some of xorg/x11).

kripken commented 2 years ago

Thanks @HinTak If upstream is on gitlab, then I think the right thing is to make the emscripten repo point to there, and then we don't need this repo.

ericoporto commented 1 year ago

It's best to use a github mirror, either here or the other one. GitHub is really good at being accessible. But instead of pushing a commit, it's best to push the exact repository.

The ports code can fetch a particular tag reference.