search

emsearcy / fluent-plugin-gelf

Buffered fluentd output plugin to GELF (Graylog2)
Apache License 2.0
33 stars 57 forks source link

GELF formatter plugin added #34

Closed aayamauchi closed 7 years ago

aayamauchi commented 7 years ago

The major change is the addition of a GELF formatter plugin. There is a bunch of clean-up and the addition of README content. Since the GELF formatter and the original output plugin share a great deal of core functionality, I've broken it out into a shared GelfUtil module. All of the hash keys have been converted to strings, as opposed to symbols to be consistent with the underlying JSON standard which requires string hash keys.

emsearcy commented 7 years ago

Note, some of these like "Adding the needed gelf version dependency since TCP is support required" could be quickly accepted if they were their own pull request. I'll make some other comments inline.

Also: is this change backwards compatible?

aayamauchi commented 7 years ago

Everything from 7b18ea6 onward should not have been in this pull request. I'm not sure what happened here. I'll try to get this fixed today and do a new pull request.

emsearcy commented 7 years ago

Sounds good. Thanks.

aayamauchi commented 7 years ago

If I can, I'll try to break this up into a series of pull requests with smaller scopes. I've had this fork for a while and made a lot of mods.

aayamauchi commented 7 years ago

The branch I used for the pull request has commit in it that I did not intend. Also, it contains three distinct change sets which should be in separate pull requests. Closing this pull request and creating new ones after cleaning things up.