search

emsesp / EMS-ESP-Flasher

Flash tool for uploading EMS-ESP firmware
MIT License
3 stars 2 forks source link

Rename the zip files #13

Open bbqkees opened 1 month ago

bbqkees commented 1 month ago

Some virus scanners or anti-malware software will flag the 'Windows.zip' file as suspicious. I think if it is renamed 'EMS-ESP Flash tool for Window.zip' or similar this will cause less issues.

proddy commented 1 month ago

Agree

it should not create zips but EMS-ESP-Flasher.exe for Windows macOS.tar Ubuntu.tar

to make it more specific.

bbqkees commented 1 month ago

The short name with 'Windows.zip' will be flagged as suspicious. If the extension is .exe it will probably also be blocked by the same anti-malware software. So the .zip is a good workaround for downloading the exe file, but then we have to make the zip file name different. For the Linux and Mac version it probably does not matter that much if it is a direct .tar/gz file instead of the .zip.

(Now I think if it it as you mentioned putting a compressed .gz file in a .zip is superfluous anyway.)