emsesp / EMS-ESP

ESP8266 firmware to read and control EMS and Heatronic compatible equipment such as boilers, thermostats, solar modules, and heat pumps

https://emsesp.github.io/docs

GNU Lesser General Public License v3.0

304 stars 97 forks source link

* fix mixerTemp and tankMiddleTemp #714

Closed joanwa closed 3 years ago

joanwa commented 3 years ago

fix mixerTemp and tankMiddleTemp naming
fix mixerTemp and tankMiddleTemp values (division by 10)
locale updates also to solar tankMiddleTemps

joanwa commented 3 years ago

712

joanwa commented 3 years ago

I think the ESP32-dev branch misses the division by 10 for the tankMiddleTemp and mixerTemp

    // Mixer temperature
    if (Helpers::hasValue(mixerTemp_)) {
        json["mixerTemp"] = (float)mixerTemp_ / 10;
    }

    // tank middle temperature (TS3)
    if (Helpers::hasValue(tankMiddleTemp_)) {
        json["tankMiddleTemp"] = (float)tankMiddleTemp_ / 10;
    }

proddy commented 3 years ago

the v3/ESP32 is a completely different beast when it comes to capturing the variables and displaying them. it's supposedly easier!

basically you need to remove the initializer in the .h header file and only modify 1 line in the .cpp file to register the value, using register_device_value. Use FL_(div10) to divide by 10. I don't mind making the port to v3 if its complicated