pump icon updates and naming update to better reflect naming schema from boiler and mixer documentation

emsesp / EMS-ESP

ESP8266 firmware to read and control EMS and Heatronic compatible equipment such as boilers, thermostats, solar modules, and heat pumps

https://emsesp.github.io/docs

GNU Lesser General Public License v3.0

305 stars 97 forks source link

pump icon updates and naming update to better reflect naming schema from boiler and mixer documentation #719

Closed joanwa closed 3 years ago

joanwa commented 3 years ago

Mixer naming
solar module: add collectorMax/MinTemp
dampedtemp -> dampedoutdoortemp
heatPump -> heatingPump (to not confuse with actual heatpumps)
tankBottomTemp2 -> tank2BottomTemp (temp of second tank, not second temp of tank)
pumpWorkMin -> pumpWorkTime (to not confuse with minimum in a few lines above)
many more

joanwa commented 3 years ago

this PR probably changes too many small things at once. Anyways, you could review it, and I could break it into smaller pieces with your comments

proddy commented 3 years ago

thanks, I'll take a look...

MichaelDvP commented 3 years ago

@proddy Due to this name changes i get a lot of mismatches when changing from esp8266 to esp32-v3. I would like to have it mostly compatible. Should i port this to v3? (i know it's manual merging). I'll also push the latest changes (WPA2, mqtt, tx_queue).

@joanwa Do you like to check the wiki section MQTT and API and document the name changes?

proddy commented 3 years ago

@proddy Due to this name changes i get a lot of mismatches when changing from esp8266 to esp32-v3. I would like to have it mostly compatible. Should i port this to v3? (i know it's manual merging). I'll also push the latest changes (WPA2, mqtt, tx_queue).

It would be great if you could manually merge into v3. I think it'll be quite complicated for @joanwa since the logic has changed. You've spent a lot of time on EMS-ESP these last days which is much appreciated. If you need any help let me know. I'll continue with the WebUI changes (#690) and after that work on the DE translation

joanwa commented 3 years ago

yeah, I was expecting some issues and discussions around this PR - now it's already merged. @MichaelDvP I'll do the wiki documentation. Will also try to figure out the actual sensor values for MM100, and not republished values for the low loss header. Let's see how far I get by myself...