search

emsesp / EMS-ESP

ESP8266 firmware to read and control EMS and Heatronic compatible equipment such as boilers, thermostats, solar modules, and heat pumps
https://emsesp.github.io/docs
GNU Lesser General Public License v3.0
299 stars 96 forks source link

Add global names to Dallas sensors to avoid ugly <unknown> and other issues in HA #747

Closed FauthD closed 3 years ago

FauthD commented 3 years ago

Hi Guys, this is a simple change that adds names so the Dallas sensors look better in HA (Integrations/MQTT page in HA See screenshot).

PS: There is a file that seems to be changed by the build process. Should it be listed into the .gitignore? interface/package-lock.json

PS2: PR is only one file. I had some issues to revoke my first changes. I am new to GitHub and git in VS-Code. Had used BitBucket and Gitkraken (+ SVN) in my previous job. Now I am retired and have more time for my hobbies :-).

screenshot_HA

proddy commented 3 years ago

Hi @FauthD, nice addition. thanks. I'm busy moving the ESP32 version to a new repo (https://github.com/emsesp/EMS-ESP32) so this sadly didn't make the cut, but we can add the change to the new one afterwards either manually or via a PR