Closed sereshqua closed 6 years ago
FYI @dligthart
Today I have checked the shop: https://nnstoffen.nl/ which has problems with EMS_Pay module to work. I was communicating with Satya while doing this.
Here is the result:
In this situation EMS_Pay module had error as well, but very weird one that was made by IndexController::ipnAction() call which is callback function called by EMS server. The error says "Invalid method Mage_Sales_Model_Order::queueNewOrderEmail(...)". The object $order is probably empty because of previous fatal errors when EMS server is doing callback call to Magento - but this has to be checked and verified.
Because of critical errors present in the shop I suggested to turn off TIG_PostNL module, eliminate critical errors and then check EMS_Pay if works without the error - on Test version.
Satya mentioned that other payment modules did work well with TIG_PostNL module which is interesting as well.
Further investigation is needed on Test version. Satya is making this can happen.
Update: I've examined _CustomwebEMSeCommerceCw module. The reason why it works and EMS_Pay does not - is completely different communication method like I assumed. _CustomwebEMSeCommerceCw is using Magento's SOAP API and iframe. No other modules run through Magento Core when communication payment is being established between shop and server. So probably (coz I didn't test it, I couldn't on Live to do so) problematic TIG shipping module is not being fired at all when Payment operations are done. It explains a lot.
_EMSPay is not developed in the best way. Making it work through SOAP makes things much more complicated and I'm not able to estimate needed time to accomplish the task. Time estimation depends roughly on EMS cooperation with setting up SOAP communication. If you examine _CustomwebEMSeCommerceCw module you can see how much work would be needed to make _EMSPay work as expected even in bad working shops full of Exceptions thrown. I think time spend on changing EMS_Pay module will be counted in weeks. Let me know about the strategy. I think I investigated everything needed to make final decision - are we going to change EMS_Pay module - a big one, or not.
Dave, please invite Satya satya@taurosmedia.com to this repo