search

emu-rs / rustual-boy

Rustual Boy - A Virtual Boy emulator.
https://rustualboy.com/
Apache License 2.0
232 stars 30 forks source link

deadlock with debugger step command #3

Closed jwestfall69 closed 7 years ago

jwestfall69 commented 7 years ago

Using the step command in the debugger will cause a deadlock when it tries to mutex lock the audio driver, because its already being held by the main emulator loop.

Also would you prefer PRs for bugs instead?

yupferris commented 7 years ago

Aha, ofc! Nice catch :)

If you wouldn't mind a PR for this would be cool if possible. I don't mind issues or PR's, whatever you'd prefer!

To fix this, passing the audio_driver reference to run_debugger_commands is probably best, just like video_driver currently.

jwestfall69 commented 7 years ago

Yeah thats what I did in my local copy.