Profile Copy is not working

emuflight / EmuConfigurator

Emuflight Configurator is a cross-platform configuration tool for the Emuflight flight control system

GNU General Public License v3.0

146 stars 25 forks source link

Profile Copy is not working #21

Open N4V1G4T0R opened 4 years ago

N4V1G4T0R commented 4 years ago

When trying to copy a Profile in the PID Tuning Tab, the settings are not copied to the target profile.

To reproduce, go into the PID Tuning Tab. Choose the profile you want to copy. Klick on "Copy profile values". Choose a Profile, where you want to copy the current settings to. (Press Save). Switch to the profile you chose to copy the settings to. You will see, that the copy did not work. The same procedure works for Rateprofiles though.

Configurator is emuflight 0.2.0.

Quick-Flash commented 4 years ago

This should be fixed with newer versions of the gui and versions of emuflight.

loutwice commented 4 years ago

actually testing on 0.2.9 on windows version - seems to works - will test more in depth

nerdCopter commented 4 years ago

Only copying on from 1 to 2 seems to work. no other variations work. (tested 0.2.12)

ghden commented 4 years ago

Same issue with latest 0.3.2 configurator, Profiles works copying from current to current + 1, you can copy from 1 to 2, but not for 1 to 3, and you can copy fine from 2 to 3.. Exact same error with rates profile..

nerdCopter commented 4 years ago

Notes for @ DEVS:

i've looked at the code again. the copy process seems to be part of the firmware MSP, not a process of the configurator. The configurator just tells MSP the source and destination. it uses the exact code for both pid-profile or rate-profile.
rateprofile seems to be fully working as of test version 0.3.3 (and i recall testing in the past which worked also)
i think this relates directly to #22 which also seems to be a firmware, non-configurator issue.

nerdCopter commented 4 years ago

i'll keep it open as reminder for devs