search

emuflight / EmuFlight

EmuFlight is flight controller software (firmware) used to fly multi-rotor craft.
GNU General Public License v3.0
453 stars 115 forks source link

OSD Languages #589

Closed JulioCesarMatias closed 3 years ago

JulioCesarMatias commented 3 years ago

hello, in the future will this be implemented in Emu? I was thinking of adding Brazilian Portuguese translations. Are you using # define, in the future will a Box (in EmuConfigurator) be implemented to select languages?

https://github.com/emuflight/EmuFlight/blob/memory-management/src/main/osd/osd_languages.h

Quick-Flash commented 3 years ago

hello, in the future will this be implemented in Emu? I was thinking of adding Brazilian Portuguese translations. Are you using # define, in the future will a Box (in EmuConfigurator) be implemented to select languages?

https://github.com/emuflight/EmuFlight/blob/memory-management/src/main/osd/osd_languages.h

just noticed this, my bad. Yes this is our plan, I haven't finished all the code for it yet though, it'll take a bit of work to make all the osd options into defines. Once its done though an option to select a language in the configurator will be added.

JulioCesarMatias commented 3 years ago

maybe creating a primary and a secondary table with the translations wouldn't be better?

for example:

https://pastebin.com/hFXLRAMp

i tested in the avr and stm32 platforms

hello, in the future will this be implemented in Emu? I was thinking of adding Brazilian Portuguese translations. Are you using # define, in the future will a Box (in EmuConfigurator) be implemented to select languages? https://github.com/emuflight/EmuFlight/blob/memory-management/src/main/osd/osd_languages.h

just noticed this, my bad. Yes this is our plan, I haven't finished all the code for it yet though, it'll take a bit of work to make all the osd options into defines. Once its done though an option to select a language in the configurator will be added.

JulioCesarMatias commented 3 years ago

some words are also bad to translate, because in Portuguese they are bigger than in English, and it ends up not fitting in the OSD

Quick-Flash commented 3 years ago

maybe creating a primary and a secondary table with the translations wouldn't be better?

for example:

https://pastebin.com/hFXLRAMp

i tested in the avr and stm32 platforms

Would be better except that we are already getting tight with memory and this would make us totally run out. Each language added would use more memory. As for some things not translating nicely perhaps some things can stay english???

JulioCesarMatias commented 3 years ago

maybe creating a primary and a secondary table with the translations wouldn't be better? for example: https://pastebin.com/hFXLRAMp i tested in the avr and stm32 platforms

Would be better except that we are already getting tight with memory and this would make us totally run out. Each language added would use more memory. As for some things not translating nicely perhaps some things can stay english???

yes, they must be in english. I made some changes (See in pastebin). Perhaps this should only be applied in FC with uC F4,F7 and H7. For F3, leave everything in English.

Quick-Flash commented 3 years ago

maybe creating a primary and a secondary table with the translations wouldn't be better? for example: https://pastebin.com/hFXLRAMp i tested in the avr and stm32 platforms

Would be better except that we are already getting tight with memory and this would make us totally run out. Each language added would use more memory. As for some things not translating nicely perhaps some things can stay english???

yes, they must be in english. I made some changes (See in pastebin). Perhaps this should only be applied in FC with uC F4,F7 and H7. For F3, leave everything in English.

Flash a stm32f411 target in a 1.0.0 branch and you will sadly see how tight memory is.

JulioCesarMatias commented 3 years ago

maybe creating a primary and a secondary table with the translations wouldn't be better? for example: https://pastebin.com/hFXLRAMp i tested in the avr and stm32 platforms

Would be better except that we are already getting tight with memory and this would make us totally run out. Each language added would use more memory. As for some things not translating nicely perhaps some things can stay english???

yes, they must be in english. I made some changes (See in pastebin). Perhaps this should only be applied in FC with uC F4,F7 and H7. For F3, leave everything in English.

Flash a stm32f411 target in a 1.0.0 branch and you will sadly see how tight memory is.

you're right!Sorry.

Quick-Flash commented 3 years ago

No worries. If you can think of a different better way to handle it let me know. Or if you come up with a great idea for memory management that would be great.

JulioCesarMatias commented 3 years ago

No worries. If you can think of a different better way to handle it let me know. Or if you come up with a great idea for memory management that would be great.

unfortunately i don't know how to optimize this, if i have a shape it is far from my knowledge. The only way out I think at the moment is to provide Emu patches with translations, and let the user choose a .hex according to their local language, or if that's not nice, it's better to leave everything in English.