Fix all warnings - Githubissues

simontoens commented 8 years ago

Xcode used to show over 100 warnings, which made it impossible to notice new warnings being introduced - this change fixes/removes all of them.

I have taken the following approach:

Warnings in core emulator code (such as "unused variable") are now being ignored (using #pragma clang diagnostic ignored). My reasoning is that I don't want to touch code that I generally don't understand fully.
For the higher level configuration/UI code, I have made the necessary code changes to get rid of the warnings, ie removed unused variables, updated deprecated methods etc.

Other cleanup changes:

Delete some of the dead code that isn't used anymore (specially xib files and related controllers).
Fix storyboard validation warnings.
Upgrade project settings. As part of this I had to set the compilation to 32 bit only. Without this, there are compilation errors; these can be fixed by adding additional casts, however I ended up with runtime errors after that. See this so question: http://stackoverflow.com/questions/22419063/error-cast-from-pointer-to-smaller-type-int-loses-information-in-eaglview-mm.

emufreak commented 8 years ago

Thanks for this. Good Idea to clean some dead/broken code up

simontoens commented 8 years ago

Thanks for merging, I am now working on hd support.

emufreak / iAmiga